[DX-1417] fix(nav): render top-level pricing nav links as clickable links#3405
Merged
Conversation
SectionNav rendered every top-level nav entry as a static heading and only made content interactive when it had a `pages` array. Top-level link-only entries — the per-product pricing pages (Pub/Sub, Chat, Spaces, LiveObjects, LiveSync) — therefore showed as dead headings with no way to reach the page. Render a top-level entry with a `link` and no `pages` as a clickable link instead, with active-state highlighting and the existing language-param preservation. Add a test covering the new behaviour. DX-1417 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jamiehenson
changed the title
jamiehenson
requested review from
a team,
AndyTWF and
kennethkalmer
and removed request for
a team
AndyTWF
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Top-level nav entries that are plain links (a
linkwith no childpages) now render as clickable links in the left sidebar instead of static headings.Resolves DX-1417.
Why
SectionNavinLeftSidebar.tsxrendered every top-level nav entry as a bold heading and only rendered anything interactive when the entry had apagesarray. The per-product pricing pages were added to the nav as top-level link-only entries, so they showed as dead headings with no way to reach the page.This affected all five products that added a top-level pricing link in the recent nav refactor:
/docs/pub-sub/pricing/docs/chat/pricing/docs/spaces/pricing/docs/liveobjects/pricing/docs/livesync/pricingOriginally spotted as the empty "LiveSync pricing" header on https://ably.com/docs/livesync/postgres.
How
In
SectionNav, a top-level entry with alinkand nopagesnow renders as aLinkwith active-page highlighting and the existing language-param preservation (buildLinkWithParams), reusing the same patterns as the child nav links. One renderer change fixes all five products at once — no nav data changes needed.Testing
href.yarn jest src/components/Layout/LeftSidebar.test.tsx— all pass.yarn lint— clean.On the review app, the "… pricing" entry in the left sidebar should now be clickable for each afflicted product:
🤖 Generated with Claude Code